Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue 
Job Compatibility to Airflow
URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r228051697
 
 

 ##########
 File path: tests/contrib/hooks/test_aws_glue_job_hook.py
 ##########
 @@ -0,0 +1,84 @@
+# -*- coding: utf-8 -*-
 
 Review comment:
   We can use these endpoints right? https://github.com/spulec/moto/pull/1750
   
   I'm ok with merging it right now with the current mock construction, but I 
think in the future we should move to moto because moto will be closer to the 
actual calls. Unfortunately we've seen wrongly mocked before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to