[
https://issues.apache.org/jira/browse/AIRFLOW-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663746#comment-16663746
]
ASF GitHub Bot commented on AIRFLOW-3257:
-----------------------------------------
ashb closed pull request #4092: [AIRFLOW-3257] Pin flake8 version to avoid
checks changing over time
URL: https://github.com/apache/incubator-airflow/pull/4092
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/setup.py b/setup.py
index b1376bb5bb..8c6c927153 100644
--- a/setup.py
+++ b/setup.py
@@ -256,7 +256,7 @@ def write_version(filename=os.path.join(*['airflow',
'qds-sdk>=1.9.6',
'rednose',
'requests_mock',
- 'flake8'
+ 'flake8==3.5.0'
]
if not PY3:
diff --git a/tox.ini b/tox.ini
index 6a55df6e5d..513bd83b1c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -66,6 +66,6 @@ commands =
basepython = python3
deps =
- flake8
+ flake8==3.5.0
commands = flake8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pin flake8 version to avoid checks changing over time
> -----------------------------------------------------
>
> Key: AIRFLOW-3257
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3257
> Project: Apache Airflow
> Issue Type: Bug
> Components: ci
> Reporter: Ash Berlin-Taylor
> Priority: Major
>
> Flake8 3.6.0 was just released and it introduced some new checks that didn't
> exist before. As a result all of our CI pipelines are now failing.
> To avoid this happening in future we should pin the version of flake8 to
> 3.5.0 (currently this is in tox.ini, and setup.py)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
