[
https://issues.apache.org/jira/browse/AIRFLOW-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664964#comment-16664964
]
ASF GitHub Bot commented on AIRFLOW-3231:
-----------------------------------------
sprzedwojski opened a new pull request #4097: [AIRFLOW-3231] Basic operators
for Google Cloud SQL
URL: https://github.com/apache/incubator-airflow/pull/4097
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3231) issue and references
it in the PR title.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Add CloudSqlInstanceInsertOperator, CloudSqlInstancePatchOperator and
CloudSqlInstanceDeleteOperator.
Each operator includes:
- core logic
- input params validation
- unit tests
- presence in the example DAG
- docstrings
- How-to and Integration documentation
Additionally, small improvements to GcpBodyFieldValidator were made:
- add simple list validation capability (type="list")
- introduced parameter allow_empty, which can be set to False
to test for non-emptiness of a string instead of specifying
a regexp.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
`test_gcp_sql_operator.py`
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
Co-authored-by: sprzedwojski <[email protected]>
Co-authored-by: potiuk <[email protected]>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Basic operators for Google Cloud SQL (deploy / patch / delete)
> --------------------------------------------------------------
>
> Key: AIRFLOW-3231
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3231
> Project: Apache Airflow
> Issue Type: New Feature
> Reporter: Szymon Przedwojski
> Assignee: Szymon Przedwojski
> Priority: Trivial
>
> In order to be able to interact with Google Cloud SQL, we need operators that
> should be able to:
> Deploy Instance (Insert or Update):
> ([https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/insert]
> [https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/update])
> Patch Instance
> ([https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/patch])
> Delete Instance:
> ([https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/delete])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
