potiuk opened a new pull request #4109: [AIRFLOW-3264] URL decoding when parsing URI for connection URL: https://github.com/apache/incubator-airflow/pull/4109 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. - https://issues.apache.org/jira/browse/AIRFLOW-3264 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Full URL decoding is performed now when parsing different components of URI for connection. This enables to configure paths to sockets including (for example ":") - so far only '/' (%2f) was hard-coded in hostname. This change introduces full decoding for all components of the URI. Note that this is potentially breaking change if someone uses % in some of their AIRFLOW_CONN_ defined connections. ### Tests - [x] My PR adds the following unit tests : tests.models.ConnectionTest: - test_connection_from_uri_with_colon_in_hostname - test_connection_from_uri_with_encoded_password - test_connection_from_uri_with_encoded_user ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. No new functionality. ### Code Quality - [x] Passes `flake8`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
