phani8996 commented on issue #4111: [AIRFLOW-3266] AWS Athena Operator and hook 
created
URL: 
https://github.com/apache/incubator-airflow/pull/4111#issuecomment-433727992
 
 
   > I'm probably not the best person to review this, having no experience with 
AWS, but one suggestion is adding some docstrings and maybe an example DAG. 
This PR is a great example: 
https://github.com/apache/incubator-airflow/pull/3969/files
   
   Doc part is still missing. I will be adding it next commit. I am more 
concerned about unit testing part. As current library does not support athena 
yet. I am hoping there is some way to test or some one can validate correctness 
and usability of above code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to