phani8996 commented on issue #4111: [AIRFLOW-3266] Add AWS Athena Operator and hook URL: https://github.com/apache/incubator-airflow/pull/4111#issuecomment-434165287 Im stuck with unit tests. After ash's suggestions, im writing some unit tests. Both unit tests and docs will pushed end of the day today. On Tue 30 Oct, 2018, 08:50 Xiaodong, <[email protected]> wrote: > *@XD-DENG* requested changes on this pull request. > > There is no docstring prepared for the AWSAthenaOperator added in this PR > ------------------------------ > > In airflow/contrib/operators/aws_athena_operator.py > <https://github.com/apache/incubator-airflow/pull/4111#discussion_r229165143> > : > > > +# > +# Unless required by applicable law or agreed to in writing, > +# software distributed under the License is distributed on an > +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > +# KIND, either express or implied. See the License for the > +# specific language governing permissions and limitations > +# under the License. > +# > + > +from airflow.models import BaseOperator > +from airflow.utils.decorators import apply_defaults > +from airflow.contrib.hooks.aws_athena_hook import AWSAthenaHook > + > + > +class AWSAthenaOperator(BaseOperator): > + > > Proper documentation (docstring) seems missing. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-airflow/pull/4111#pullrequestreview-169599205>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ALlBaATnjDw6VCWwZXYiR5SI3ZMvuquHks5up8WWgaJpZM4X94fP> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
