ashb commented on a change in pull request #4108: [AIRFLOW-3263] Ignore
exception when 'run' tries to kill already killed job
URL: https://github.com/apache/incubator-airflow/pull/4108#discussion_r229651948
##########
File path: airflow/utils/helpers.py
##########
@@ -234,7 +234,15 @@ def on_terminate(p):
children = parent.children(recursive=True)
children.append(parent)
- log.info("Sending %s to GPID %s", sig, os.getpgid(pid))
+ try:
+ pg = os.getpgid(pid)
+ except OSError as err:
+ # Skip if not such process - we experience a race and it just
terminated :)
+ if err.errno == 3:
Review comment:
Worth comparing to `errno.ESRCH` to avoid magic number?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
