XD-DENG commented on a change in pull request #4118: [AIRFLOW-3271] Airflow
RBAC Permissions modification via UI do not persist
URL: https://github.com/apache/incubator-airflow/pull/4118#discussion_r229934643
##########
File path: tests/www_rbac/test_security.py
##########
@@ -107,6 +107,20 @@ def test_init_role_modelview(self):
self.assertIsNotNone(role)
self.assertEqual(len(role_perms), len(role.permissions))
+ def test_update_and_verify_permission_role(self):
+ self.security_manager.init_role('User', [], [])
Review comment:
Seems using `'User'` here break `test_log_success_for_user
(tests.www_rbac.test_views.TestDagACLView)`.
May I suggest to use a "fake" role here for this test, say
`self.security_manager.init_role('Test_Role', [], [])`, then make the same
change for line 119 as well.
It should help pass the CI tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
