ashb commented on a change in pull request #4069: [AIRFLOW-3233] Fix deletion
of DAGs in the UI
URL: https://github.com/apache/incubator-airflow/pull/4069#discussion_r231132887
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -191,11 +191,11 @@ <h2>DAGs</h2>
</a>
<!-- Delete -->
- <a href="{{ url_for('airflow.delete', dag_id=dag.dag_id) }}"
- onclick="return confirmDeleteDag('{{ dag.safe_dag_id }}')">
+ <!-- Use dag_id instead of dag.dag_id, because the DAG might
not exist in the webserver's DagBag -->
Review comment:
Minor nit: this includes the comment in thee HTML which we don't need. If
you think the comment is useful then:
```suggestion
{# Use dag_id instead of dag.dag_id, because the DAG might
not exist in the webserver's DagBag #}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
