ashb commented on issue #2460: [AIRFLOW-1424] make the next execution date of 
DAGs visible
URL: 
https://github.com/apache/incubator-airflow/pull/2460#issuecomment-436576397
 
 
   Specifically this:
   
   ```
           self.assertEqual(test_dag.next_run_date, DEFAULT_DATE)
           self.assertEqual(test_dag.next_execution_date,
                            DEFAULT_DATE + datetime.timedelta(days=1)) 
   ```
   
   The looks like next_run_date is next, and next_execution_date is 
one-after-next.
   
   Which CLI command were you mirroring?
   
   To be clear: next_execution_date as you have it is wrong. execution_date and 
run_date are the same concept so this test and having an extra property is 
wrong. 
https://github.com/apache/incubator-airflow/blob/master/airflow/models.py#L1843 
is the behaviour we should have.
   
   If you think I am missing something (entirely possible! I am far from 
infallible) please point me at existing parts of the code base.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to