[
https://issues.apache.org/jira/browse/AIRFLOW-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679808#comment-16679808
]
ASF GitHub Bot commented on AIRFLOW-3315:
-----------------------------------------
feluelle opened a new pull request #4161: [AIRFLOW-3315] Add
ImapAttachmentSensor
URL: https://github.com/apache/incubator-airflow/pull/4161
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3315
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR adds a sensor that pokes a mail server for attachments in mails with
a given name.
If an attachment has been found it will immediately stop and return that an
attachment has been found for the given name.
**This PR also updates the license header in imap_hook and test_imap_hook**
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This PR adds tests for:
* test_poke_with_attachment_found
* test_poke_with_attachment_not_found
* test_poke_with_check_regex_true (tests if `check_regex=True` will be
passed to the Hook's method)
* test_poke_with_different_mail_folder (tests a mail folder other than
`INBOX`)
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add ImapAttachmentSensor to poke for mail attachments
> -----------------------------------------------------
>
> Key: AIRFLOW-3315
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3315
> Project: Apache Airflow
> Issue Type: New Feature
> Reporter: Felix Uellendall
> Assignee: Felix Uellendall
> Priority: Major
>
> This kind of sensor pokes a mail server for attachments in mails with a given
> name.
> It will use the existing
> [ImapHook|https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-2780]
> to establish a connection to the mail server
> and search for the attachment in all mails.
> If an attachment has been found it will immediately stop and return that an
> attachment has been found for the given name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
