ashb opened a new pull request #4162: [AIRFLOW-XXX] Speed up RBAC view tests
URL: https://github.com/apache/incubator-airflow/pull/4162
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] No jira needed I think?
   
   ### Description
   
   - [x] Not re-creating the FAB app ones per test functions took the run time 
of
   the TestAirflowBaseViews from 223s down to 53s on my laptop, _and_ made
   it only print the deprecation warning (fixed in another PR already open)
   once instead of 10+ times.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to