[jira] [Commented] (AIRFLOW-3323) Support Basic Authentication for Flower

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/AIRFLOW-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681196#comment-16681196
 ] 

ASF GitHub Bot commented on AIRFLOW-3323:
-----------------------------------------

XD-DENG opened a new pull request #4166: [AIRFLOW-3323] Support HTTP basic 
authentication for Airflow Flower
URL: https://github.com/apache/incubator-airflow/pull/4166
 
 
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3323
   
   
   ### Description
   
   The current `airflow flower` doesn't come with any authentication. This may 
make essential information exposed to in an untrusted environment.
   
   Currently Flower itself supports
   - HTTP Basic Authentication
   - Google OAuth 2.0
   - GitHub OAuth
   
   Given Flower is not really the most essential component of Airflow, we don't 
have to support all its authentication methods. But may be good to at least 
support **Basic Authentication**.
   
   Ref:
   https://flower.readthedocs.io/en/latest/auth.html
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
   ### Screenshots
   
   #### 1. Asking for ID/password
   <img width="1125" alt="screen shot 2018-11-09 at 5 31 32 pm" 
src="https://user-images.githubusercontent.com/11539188/48256289-1cff3400-e44a-11e8-9112-5f1277c65a84.png";>
   
   #### 2. Failed authentication
   <img width="973" alt="screen shot 2018-11-09 at 5 31 42 pm" 
src="https://user-images.githubusercontent.com/11539188/48256297-238dab80-e44a-11e8-8b32-1487b49d1f24.png";>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support Basic Authentication for Flower
> ---------------------------------------
>
>                 Key: AIRFLOW-3323
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3323
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: celery
>    Affects Versions: 1.10.0
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Critical
>
> The current `airflow flower` doesn't come with any authentication. This may 
> make essential information exposed to in an untrusted environment.
> Currently Flower itself supports
>  * HTTP Basic Authentication
>  * Google OAuth 2.0
>  * GitHub OAuth
> Given Flower is not really the most essential component of Airflow, we don't 
> have to support all its authentication methods. But may be good to at least 
> support Basic Authentication.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)