ashb commented on a change in pull request #4006: [AIRFLOW-3164] Verify server
certificate when connecting to LDAP
URL: https://github.com/apache/incubator-airflow/pull/4006#discussion_r232260243
##########
File path: airflow/contrib/auth/backends/ldap_auth.py
##########
@@ -55,16 +55,18 @@ class LdapException(Exception):
def get_ldap_connection(dn=None, password=None):
- tls_configuration = None
- use_ssl = False
try:
cacert = configuration.conf.get("ldap", "cacert")
- tls_configuration = Tls(validate=ssl.CERT_REQUIRED,
ca_certs_file=cacert)
- use_ssl = True
- except Exception:
+ except AirflowConfigException:
pass
Review comment:
It's not required - if it is not specified then it will use the normal
system cert chain to verify the LDAP server cert.
This is only required if a self-signed/private-CA is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
