[
https://issues.apache.org/jira/browse/AIRFLOW-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681869#comment-16681869
]
ASF GitHub Bot commented on AIRFLOW-3275:
-----------------------------------------
potiuk opened a new pull request #4170: [AIRFLOW-3275] Implements Google Cloud
SQL Query operator
URL: https://github.com/apache/incubator-airflow/pull/4170
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3275
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Operator that performs a DDL or DML SQL query in Google Cloud SQL instance.
The DQL (retrieving data from Google Cloud SQL) is not supported - you might
run the SELECT queries but results of those queries are discarded.
You should be able specify various connectivity methods to connect to a
running instance - starting from Public IP plain connection, through Public
IP
with SSL or both TCP and socket connection via Cloud SQL Proxy.
The proxy should be downloaded and started/stopped dynamically as
needed by the operator.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
tests.contrib.operators/test_gcp_sql_operator
CloudSqlQueryValidationTest
CloudSqlProxyIntegrationTest
CloudSqlQueryExampleDagsIntegrationTest
Note that the two *IntegrationTest above are skipped by default - they
require special configuration - i.e folder and key to authorise in GCP which we
do not have for the Apache repo yet. It is useful for development where you can
configure your environment to run the integration tests in your own GCP
project. This is a working proof of concept on how GCP integration tests can
work - which we might soon turn into more general proposal on how to handle it.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Google Cloud SQL Query operator
> -------------------------------
>
> Key: AIRFLOW-3275
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3275
> Project: Apache Airflow
> Issue Type: New Feature
> Components: contrib
> Reporter: Jarek Potiuk
> Priority: Major
>
> Operator that performs a DDL or DML SQL query in Google Cloud SQL instance.
> The DQL (retrieving data from Google Cloud SQL) is not supported - you might
> run the SELECT queries but results of those queries are discarded.
> You should be able specify various connectivity methods to connect to running
> instance - starting from Public IP plain connection through Public IP with
> SSL or both TCP and socket connection via Cloud SQL Proxy. The proxy should
> be downloaded and started/stopped dynamically as needed by the operator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
