potiuk commented on a change in pull request #4170: [AIRFLOW-3275] Implement Google Cloud SQL Query operator URL: https://github.com/apache/incubator-airflow/pull/4170#discussion_r232591485
########## File path: airflow/contrib/example_dags/example_gcp_compute.py ########## @@ -21,15 +21,15 @@ Example Airflow DAG that starts, stops and sets the machine type of a Google Compute Engine instance. -This DAG relies on the following Airflow variables -https://airflow.apache.org/concepts.html#variables +This DAG relies on the following OS environment variables Review comment: This is because of the dicsussion here: https://lists.apache.org/[email protected]:lte=1M:variables . We are moving away from airflow variables in DAGs (at least in the top-level) because it might show an example of anti-pattern - using airflow variables in DAGs at top level causes a lot of opened coneections to the DB every 5 seconds. We also change a way we run the DAGs to the unit test-driven approach (see below) and it makes it easier to set environment variables in IDE to run them very easily. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
