[ 
https://issues.apache.org/jira/browse/AIRFLOW-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684086#comment-16684086
 ] 

ASF GitHub Bot commented on AIRFLOW-3306:
-----------------------------------------

ashb closed pull request #4146: [AIRFLOW-3306] Disable flask-sqlalchemy 
modification tracking.
URL: https://github.com/apache/incubator-airflow/pull/4146
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/www_rbac/app.py b/airflow/www_rbac/app.py
index e7f5a1e976..69b5acbd2b 100644
--- a/airflow/www_rbac/app.py
+++ b/airflow/www_rbac/app.py
@@ -50,6 +50,7 @@ def create_app(config=None, session=None, testing=False, 
app_name="Airflow"):
     airflow_home_path = conf.get('core', 'AIRFLOW_HOME')
     webserver_config_path = airflow_home_path + '/webserver_config.py'
     app.config.from_pyfile(webserver_config_path, silent=True)
+    app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
     app.config['APP_NAME'] = app_name
     app.config['TESTING'] = testing
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Disable unused flask-sqlalchemy modification tracking
> -----------------------------------------------------
>
>                 Key: AIRFLOW-3306
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3306
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Josh Carp
>            Assignee: Josh Carp
>            Priority: Trivial
>
> By default, flask-sqlalchemy tracks model changes for its event system, which 
> adds some overhead. Since I don't think we're using the flask-sqlalchemy 
> event system, we should be able to turn off modification tracking and improve 
> performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to