[
https://issues.apache.org/jira/browse/AIRFLOW-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685625#comment-16685625
]
ASF GitHub Bot commented on AIRFLOW-3271:
-----------------------------------------
smithakoduri opened a new pull request #4118: [AIRFLOW-3271] Airflow RBAC
Permissions modification via UI do not persist
URL: https://github.com/apache/incubator-airflow/pull/4118
Fix is added to not reset the database whenever a new process comes up (or
init_roles is called). Otherwise Airflow RBAC permissions that are modified, do
not persist for long
"test_update_and_verify_permission_role" test has been added.
Make sure you have checked _all_ steps below.
Jira
- [x] My PR addresses the following AIRFLOW-3271 issues and references them
in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
-https://issues.apache.org/jira/browse/AIRFLOW-3271
Description
- [x] Here are some details about my PR, including screenshots of any UI
changes: My PR adds a fix to make Airflow RBAC permission changes to the
database persist. The RBAC permission will only be reset in the very beginning
and later when init_role is called, it will keep the existing permission as is
and will not reset it. Previously, when any change is made to the RBAC
permissions, those changes used to get reset when init_roles is called (for
every new process creation). Because of which, any new RBAC permission added
via UI used to be missing in the database after sometime.
### Tests
- [x] My PR adds the following unit tests:
test_update_and_verify_permission_role
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
No new functionality
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Airflow RBAC Permissions modification via UI do not persist
> -----------------------------------------------------------
>
> Key: AIRFLOW-3271
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3271
> Project: Apache Airflow
> Issue Type: Bug
> Affects Versions: 1.10.0
> Reporter: Smitha Koduri
> Assignee: Smitha Koduri
> Priority: Major
> Fix For: 1.10.2
>
>
> After upgrading Airflow to 1.10, we have noticed that when attempting to add
> a new permission-role mapping (via UI), initially it gets successfully added
> to db. But later, the entry doesn't persist in the db.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
