[
https://issues.apache.org/jira/browse/AIRFLOW-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685863#comment-16685863
]
ASF GitHub Bot commented on AIRFLOW-3336:
-----------------------------------------
rmn36 opened a new pull request #4182: [AIRFLOW-3336] Add new TriggerRule that
will consider ancestors as s…
URL: https://github.com/apache/incubator-airflow/pull/4182
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3336/) issues and
references them in the PR title.
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Take the case where a task has 2 or more upstream parents and 1 or more of
them can skipped. If TriggerRule ALL_DONE is used then the task will trigger
even when upstream tasks fail. However if TriggerRule ALL_SUCCESS is used the
task won't be triggered if any upstream are skipped. This creates a gap in
functionality where it is necessary for "skipped" to be treated as "success" so
that the task only runs if all parents succeed or are skipped. Said another way
this allows tasks to be run if all ancestors do NOT fail.
Therefore, a new trigger rule has been added that will count skipped as
success to close this gap in functionality.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [X] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add ability for "skipped" state to be considered success
> --------------------------------------------------------
>
> Key: AIRFLOW-3336
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3336
> Project: Apache Airflow
> Issue Type: Improvement
> Components: DAG
> Reporter: Ryan Nowacoski
> Assignee: Ryan Nowacoski
> Priority: Trivial
> Labels: beginner, usability
>
> Take the case where a task has 2 or more upstream parents and 1 or more of
> them can skipped. If TriggerRule ALL_DONE is used then the task will trigger
> even when upstream tasks fail. However if TriggerRule ALL_SUCCESS is used the
> task won't be triggered if any upstream are skipped. This creates a gap in
> functionality where it is necessary for "skipped" to be treated as "success"
> so that the task only runs if all parents succeed or are skipped. Said
> another way this allows tasks to be run if all ancestors do NOT fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
