gerardo commented on issue #3815: [AIRFLOW-2973] Add Python 3.6 to Supported Prog Langs URL: https://github.com/apache/incubator-airflow/pull/3815#issuecomment-438530066 @Fokko @kaxil @tedmiston I've done some more work on https://github.com/apache/incubator-airflow-ci/pull/4, but I've found a few issues with the Python3.6 upgrade, plus other issues with some assumptions that the test suite makes: - [`tests.operators.test_virtualenv_operator.test_python_3`](https://github.com/apache/incubator-airflow/blob/6a7f3887460c91bc4da90fe8d31836a225324a1a/tests/operators/test_virtualenv_operator.py#L124) fails when run with the `python2` image ([logs](https://travis-ci.com/gerardo/incubator-airflow/jobs/157826745#L4443)). Using `skipIf` to check what python version is present should be enough. And maybe we should do the same with [test_python_2 and test_python_2.7](https://github.com/apache/incubator-airflow/blob/6a7f3887460c91bc4da90fe8d31836a225324a1a/tests/operators/test_virtualenv_operator.py#L124) - [tests.operators.test_virtualenv_operator.test_string_args](https://github.com/apache/incubator-airflow/blob/6a7f3887460c91bc4da90fe8d31836a225324a1a/tests/operators/test_virtualenv_operator.py#L170) is a weird test. It uses a method called `_invert_python_major_version()` to use the opposite version to the one available, which is causing problems with [python2 tests](https://travis-ci.com/gerardo/incubator-airflow/jobs/157826745#L4503). Do you guys understand this test? - There was a change between `python3.5` and `python3.6` in the error message emitted when an object is not serializable ([logs](https://travis-ci.com/gerardo/incubator-airflow/jobs/157826750#L4568)). It's just a matter of changing the test to check for the new message format. - One of the tz tests is failing as well, more specifically, `test_following_previous_schedule_daily_dag_CEST_to_CET` ([logs](https://travis-ci.com/gerardo/incubator-airflow/jobs/157826750#L4367)). I'm not sure where to start. It seems to happen only with `python3.6`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
