[
https://issues.apache.org/jira/browse/AIRFLOW-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686888#comment-16686888
]
ASF GitHub Bot commented on AIRFLOW-3339:
-----------------------------------------
ashb opened a new pull request #4187: [AIRFLOW-3339] Update DockerOperator for
Docker-py 3.0.0 API changes
URL: https://github.com/apache/incubator-airflow/pull/4187
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] When we updated the version of docker.py in #4049 we missed a breaking
change. The API of `wait()` changed to return a dict, not just a number so this
Operator wasn't actually working, but the tests were passing because the
return was mocked in-correctly.
Since it appears that the python Docker module follows semver, with breaking
changes only on major versions I have also changed the format specifier so we
don't pull in 4.0.0 accidentally in the future.
I also removed `shm_size` from kwargs passed to BaseOperator to avoid
the deprecation warning about unknown args.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix timezone error
> ------------------
>
> Key: AIRFLOW-3339
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3339
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 1.10.1
> Reporter: Ikar Pohorsky
> Assignee: Ash Berlin-Taylor
> Priority: Blocker
>
> From slack:
> nicor88 8:34 AM
> {quote}
> Hey all, we are having issue with our scheduler, in the latest release 1.10.1
> due to this error:
> {noformat}
> Process DagFileProcessor94249-Process:
> Traceback (most recent call last):
> File "/usr/local/lib/python3.6/multiprocessing/process.py", line 258, in
> _bootstrap
> self.run()
> File "/usr/local/lib/python3.6/multiprocessing/process.py", line 93, in run
> self._target(*self._args, **self._kwargs)
> File "/usr/local/lib/python3.6/site-packages/airflow/jobs.py", line 389, in
> helper
> pickle_dags)
> File "/usr/local/lib/python3.6/site-packages/airflow/utils/db.py", line 74,
> in wrapper
> return func(*args, **kwargs)
> File "/usr/local/lib/python3.6/site-packages/airflow/jobs.py", line 1846, in
> process_file
> self._process_dags(dagbag, dags, ti_keys_to_schedule)
> File "/usr/local/lib/python3.6/site-packages/airflow/jobs.py", line 1426, in
> _process_dags
> dag_run = self.create_dag_run(dag)
> File "/usr/local/lib/python3.6/site-packages/airflow/utils/db.py", line 74,
> in wrapper
> return func(*args, **kwargs)
> File "/usr/local/lib/python3.6/site-packages/airflow/jobs.py", line 835, in
> create_dag_run
> next_start = dag.following_schedule(now)
> File "/usr/local/lib/python3.6/site-packages/airflow/models.py", line 3396,
> in following_schedule
> tz = pendulum.timezone(self.timezone.name)
> AttributeError: 'NoneType' object has no attribute 'name'
> {noformat}
> We have a timezone setup in the config
> {quote}
> eamon [Today at 9:41 AM]
> {quote}
> @nicor88 I saw that in the logs also, fwiw it seemed to fail at the first
> dag run but then subsequent attempts seemed to work.
> {quote}
> 
> nicor88 [3 hours ago]
> {quote}
> I tried but the daily jobs are stacked
> {quote}
> 
> eamon [2 hours ago]
> {quote}
> so nothing getting scheduled? This is the behaviour I've observed also. When
> I saw that particular error, it seemed to correct itself so I discounted that
> as the root cause but could be it.
> {quote}
> 
> eamon [2 hours ago]
> {quote}
> maybe try a task without a timezone.
> {quote}
> 
> porn [1 hour ago]
> {quote}
> dammit, same problem here ({{1.10.1-rc1}})
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> we have timezone setup as utc in the config, and the start_date is setup
> like: datetime(2018, 7, 23)
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> we reverted to the stable release 1.10.0
> {quote}
> 
> porn [1 hour ago]
> {quote}
> {{default_timezone = utc}} in config too,
> the DAG parameters:
> {noformat}
> schedule_interval = "0 14 * * *",
> start_date = datetime(2017, 8, 29, hour=1)
> {noformat}
> {quote}
> 
> porn [1 hour ago]
> {quote}
> I need to add that this happened to me only when tried to manually execute
> (from UI) the task that is periodical, but haven't ran yet. Can you @nicor88
> confirm this was your case too?
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> in our case the daily jobs were not scheduled at all
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> that’s why I got suspiscious and check (edited)
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> we install Airflow from Github directly, pointing to the stable branch. Now
> we recovered pointing to a specific release
> {quote}
> 
> porn [1 hour ago]
> {quote}
> it is a pre-release actually
> {quote}
> nicor88 [1 hour ago]
> {quote}
> it’s my bad that we use the v1-10-stable branch from Github
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> instead of using the tagged release (edited)
> {quote}
> 
> nicor88 [1 hour ago]
> {quote}
> lesson learned
> {quote}
> 
> porn [14 minutes ago]
> {quote}
> ok, just downgraded to {{v1.10.1b1}} and got the same error
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
