kaxil commented on a change in pull request #4187: [AIRFLOW-3343] Update
DockerOperator for Docker-py 3.0.0 API changes
URL: https://github.com/apache/incubator-airflow/pull/4187#discussion_r233625671
##########
File path: airflow/operators/docker_operator.py
##########
@@ -230,9 +231,9 @@ def execute(self, context):
line = line.decode('utf-8')
self.log.info(line)
- exit_code = self.cli.wait(self.container['Id'])
- if exit_code != 0:
- raise AirflowException('docker container failed')
+ result = self.cli.wait(self.container['Id'])
+ if result['StatusCode'] != 0:
Review comment:
Can we change this to:
```
if 'StatusCode' in result and result['StatusCode'] != 0:
```
??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
