[ https://issues.apache.org/jira/browse/AIRFLOW-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687670#comment-16687670 ]
ASF GitHub Bot commented on AIRFLOW-3345: ----------------------------------------- sprzedwojski opened a new pull request #4192: [AIRFLOW-3345] Add Google Cloud Storage (GCS) operators for ACL URL: https://github.com/apache/incubator-airflow/pull/4192 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3345) issues and references them in the PR title. ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Add 2 operators for adding ACL entries to GCS buckets and objects: - GoogleCloudStorageBucketCreateAclEntryOperator - GoogleCloudStorageObjectCreateAclEntryOperator They serve to add permissions to GCS buckets / object for users / service accounts from Airflow. ### Tests - [x] My PR adds the following unit tests: `test_gcs_acl_operator.py`: - `test_bucket_create_acl` - `test_bucket_create_acl` `example_gcs_acl.py` (serving and an integration test) ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. ### Code Quality - [x] Passes `flake8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Google Cloud Storage (GCS) operators for ACL > ------------------------------------------------ > > Key: AIRFLOW-3345 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3345 > Project: Apache Airflow > Issue Type: New Feature > Components: gcp > Reporter: Szymon Przedwojski > Assignee: Szymon Przedwojski > Priority: Minor > > Add operators to be able to add ACL entries to GCS buckets and objects: > * > [https://cloud.google.com/storage/docs/json_api/v1/objectAccessControls/insert] > * > [https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)