[
https://issues.apache.org/jira/browse/AIRFLOW-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688411#comment-16688411
]
ASF GitHub Bot commented on AIRFLOW-3353:
-----------------------------------------
ashb closed pull request #4195: [AIRFLOW-3353] Pin redis version
URL: https://github.com/apache/incubator-airflow/pull/4195
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/setup.py b/setup.py
index 8c6c927153..fa56c1b9a4 100644
--- a/setup.py
+++ b/setup.py
@@ -218,7 +218,7 @@ def write_version(filename=os.path.join(*['airflow',
postgres = ['psycopg2-binary>=2.7.4']
qds = ['qds-sdk>=1.9.6']
rabbitmq = ['librabbitmq>=1.6.1']
-redis = ['redis>=2.10.5']
+redis = ['redis>=2.10.5,<3.0.0']
s3 = ['boto3>=1.7.0, <1.8.0']
salesforce = ['simple-salesforce>=0.72']
samba = ['pysmbclient>=0.1.3']
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> redis-py 3.0.0 dependency breaks celery executor
> ------------------------------------------------
>
> Key: AIRFLOW-3353
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3353
> Project: Apache Airflow
> Issue Type: Bug
> Components: celery
> Affects Versions: 1.10.0
> Reporter: Stefan Seelmann
> Assignee: Iuliia Volkova
> Priority: Major
>
> redis-py 3.0.0 was just released. Airflow 1.10.0 defines redis>=2.10.5 so
> installs redis-py 3.0.0 now.
> Error in worker below.
> Workaround: Pin redis==2.10.6 (e.g. in constraints.txt)
> {code}
> [2018-11-15 12:06:18,441: CRITICAL/MainProcess] Unrecoverable error:
> AttributeError("'float' object has no attribute 'items'",)
> Traceback (most recent call last):
> File "/usr/local/lib/python3.6/site-packages/celery/worker/worker.py", line
> 205, in start
> self.blueprint.start(self)
> File "/usr/local/lib/python3.6/site-packages/celery/bootsteps.py", line
> 119, in start
> step.start(parent)
> File "/usr/local/lib/python3.6/site-packages/celery/bootsteps.py", line
> 369, in start
> return self.obj.start()
> File
> "/usr/local/lib/python3.6/site-packages/celery/worker/consumer/consumer.py",
> line 317, in start
> blueprint.start(self)
> File "/usr/local/lib/python3.6/site-packages/celery/bootsteps.py", line
> 119, in start
> step.start(parent)
> File
> "/usr/local/lib/python3.6/site-packages/celery/worker/consumer/consumer.py",
> line 593, in start
> c.loop(*c.loop_args())
> File "/usr/local/lib/python3.6/site-packages/celery/worker/loops.py", line
> 91, in asynloop
> next(loop)
> File "/usr/local/lib/python3.6/site-packages/kombu/asynchronous/hub.py",
> line 354, in create_loop
> cb(*cbargs)
> File "/usr/local/lib/python3.6/site-packages/kombu/transport/redis.py",
> line 1040, in on_readable
> self.cycle.on_readable(fileno)
> File "/usr/local/lib/python3.6/site-packages/kombu/transport/redis.py",
> line 337, in on_readable
> chan.handlers[type]()
> File "/usr/local/lib/python3.6/site-packages/kombu/transport/redis.py",
> line 724, in _brpop_read
> self.connection._deliver(loads(bytes_to_str(item)), dest)
> File
> "/usr/local/lib/python3.6/site-packages/kombu/transport/virtual/base.py",
> line 983, in _deliver
> callback(message)
> File
> "/usr/local/lib/python3.6/site-packages/kombu/transport/virtual/base.py",
> line 632, in _callback
> self.qos.append(message, message.delivery_tag)
> File "/usr/local/lib/python3.6/site-packages/kombu/transport/redis.py",
> line 149, in append
> pipe.zadd(self.unacked_index_key, time(), delivery_tag) \
> File "/usr/local/lib/python3.6/site-packages/redis/client.py", line 2263,
> in zadd
> for pair in iteritems(mapping):
> File "/usr/local/lib/python3.6/site-packages/redis/_compat.py", line 123,
> in iteritems
> return iter(x.items())
> AttributeError: 'float' object has no attribute 'items'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
