[
https://issues.apache.org/jira/browse/AIRFLOW-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690025#comment-16690025
]
ASF GitHub Bot commented on AIRFLOW-3360:
-----------------------------------------
jongsy opened a new pull request #4201: [AIRFLOW-3360] Make the DAGs search
respect other querystring parameters
URL: https://github.com/apache/incubator-airflow/pull/4201
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Search will append to the query string rather than replacing it. Allows
users to decide whether they want to search for hidden DAGs.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
No existing tests around the DAGs template.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Search does not respect ShowPaused Dags querystring
> ---------------------------------------------------
>
> Key: AIRFLOW-3360
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3360
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
> Affects Versions: 1.10.0, 2.0.0
> Environment: All
> Reporter: Jonathan Burgess
> Assignee: Jonathan Burgess
> Priority: Minor
> Labels: rbac, ui
>
> After submitting a search query on the DAGs page the showPaused parameter
> will revert to the default. This is troublesome when using the search to find
> paused dags if the default is ShowPaused is False.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
