kaxil commented on a change in pull request #4194: [AIRFLOW-3352] Fix showing
config on RBAC UI when expose_config is False
URL: https://github.com/apache/incubator-airflow/pull/4194#discussion_r234366909
##########
File path: tests/www_rbac/test_views.py
##########
@@ -448,13 +448,23 @@ def test_refresh(self):
class TestConfigurationView(TestBase):
- def test_configuration(self):
+ def test_configuration_do_not_expose_config(self):
self.logout()
self.login()
+ conf.set("webserver", "expose_config", "False")
Review comment:
@phani8996 Because it was checking the wrong condition.
`test_configuration_do_not_expose_config` should have `expose_config=False`,
we had it `True`. I have fixed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
