BasPH opened a new pull request #4206: [AIRFLOW-XXX] Remove spots in all 
Airflow logos
URL: https://github.com/apache/incubator-airflow/pull/4206
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   Turns out I wasn't very consistent in my PR removing the spot in the Airflow 
logo (https://github.com/apache/incubator-airflow/pull/4065). The file size 
increased by 22KB and there are 4 more Airflow logo images containing the same 
spot.
   
   I this PR, I drastically reduced image size by exporting with Photoshop, 
removing all metadata, and with 8-bit and RGB colors. This was already the case 
in all Airflow logos, but turns out my Photoshop stored with 24-bit colors by 
default. The end result:
   
   airflow/www/static/pin_large.jpg | 400kb -> 316kb
   airflow/www/static/pin_large.png | 358kb -> 104kb
   airflow/www_rbac/static/pin_large.jpg | 400kb -> 316kb
   airflow/www_rbac/static/pin_large.png | 358kb -> 104kb
   docs/img/pin_large.png | 381kb -> 104kb
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   No tests required.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to