[
https://issues.apache.org/jira/browse/AIRFLOW-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696436#comment-16696436
]
ASF GitHub Bot commented on AIRFLOW-1739:
-----------------------------------------
msumit closed pull request #2709: [AIRFLOW-1739] Resolve TestDbApiHook naming
ambiguity
URL: https://github.com/apache/incubator-airflow/pull/2709
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/hooks/test_dbapi_hook.py b/tests/hooks/test_dbapi_hook.py
index 3484ee99da..10cd09dea4 100644
--- a/tests/hooks/test_dbapi_hook.py
+++ b/tests/hooks/test_dbapi_hook.py
@@ -34,13 +34,13 @@ def setUp(self):
self.conn.cursor.return_value = self.cur
conn = self.conn
- class TestDBApiHook(DbApiHook):
+ class UnitTestDbApiHook(DbApiHook):
conn_name_attr = 'test_conn_id'
def get_conn(self):
return conn
- self.db_hook = TestDBApiHook()
+ self.db_hook = UnitTestDbApiHook()
def test_get_records(self):
statement = "SQL"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup naming ambiguity with TestDbApiHook test class
> ------------------------------------------------------
>
> Key: AIRFLOW-1739
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1739
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Andy Hadjigeorgiou
> Assignee: Andy Hadjigeorgiou
> Priority: Trivial
>
> The TestDbApiHook class creates a class whose name is TestDBApiHook - I'm
> proposing a simple naming change to make sure the two are distinguishable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
