[
https://issues.apache.org/jira/browse/AIRFLOW-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697578#comment-16697578
]
ASF GitHub Bot commented on AIRFLOW-3066:
-----------------------------------------
hugoprudente opened a new pull request #4230: [AIRFLOW-3066] Adding support for
Parameters on AWS Batch Operator
URL: https://github.com/apache/incubator-airflow/pull/4230
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-3066) issues and references
them in the PR "\[AIRFLOW-3066\] Add job parameters to AWSbatch Operator"
### Description
- [x] Added the parameters for using dynamic commands on Job Execution
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
```
nosetests -v tests/contrib/operators/test_awsbatch_operator.py
test_check_success_task_not_raises
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_check_success_tasks_raises
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_check_success_tasks_raises_failed
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_check_success_tasks_raises_multiple
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_check_success_tasks_raises_pending
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_execute_with_failures
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_execute_without_failures
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_init
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_template_fields_overrides
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
test_wait_end_tasks
(tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
----------------------------------------------------------------------
Ran 10 tests in 0.146s
OK
[2018-11-24 00:59:23,032] {settings.py:203} DEBUG - Disposing DB connection
pool (PID 12221)
```
### Commits
- [x] My commits all reference Jira issues: [AIRFLOW-3066] Adding support
for AWS Batch parameters
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add job parameters to AWSbatch Operator
> ---------------------------------------
>
> Key: AIRFLOW-3066
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3066
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib, operators
> Reporter: Raphael Norman-Tenazas
> Assignee: Hugo Prudente
> Priority: Minor
> Labels: AWS, easyfix, features, newbie
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Sometimes it is necessary to add parameters at runtime to AWS batch jobs in a
> workflow. Currently, the AWSbatchOperator does not support this, and will use
> the default parameters defined in the AWS job description.
> This can be implemented by adding a job_description={} parameter to the
> AWSBatchOperator's __init__ and pass that into the client.submit_job call
> with the keyword parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
