xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass
kerberos cli args keytab and principal to kerberos…
URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236334348
##########
File path: airflow/security/kerberos.py
##########
@@ -55,8 +57,8 @@ def renew_from_kt():
if subp.returncode != 0:
log.error("Couldn't reinit from keytab! `kinit' exited with
%s.\n%s\n%s" % (
subp.returncode,
- b"\n".join(subp.stdout.readlines()),
- b"\n".join(subp.stderr.readlines())))
+ "\n".join(subp.stdout.readlines()),
+ "\n".join(subp.stderr.readlines())))
Review comment:
@ashb ,
also b"\n".join(subp.stdout.readlines()) caused error on 3.5, it was not
catched because wasn't covered with tests
error in 3.5 -
` b"\n".join(subp.stderr.readlines())))
TypeError: sequence item 0: expected a bytes-like object, str found`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
