XD-DENG commented on a change in pull request #4253: [AIRFLOW-3414] Fix
reload_module in DagFileProcessorAgent
URL: https://github.com/apache/incubator-airflow/pull/4253#discussion_r237724308
##########
File path: airflow/logging_config.py
##########
@@ -73,7 +73,7 @@ def configure_logging():
validate_logging_config(logging_config)
- return logging_config
+ return logging_config, logging_class_path
Review comment:
Thanks @KevinYang21 !
Is there any specific reason that we need to return `logging_config`?
Before this PR: `configure_logging()` is invoked in `airflow/settings.py`,
but seems what it returns is not used.
After this PR: `logging_class_path` is returned by `configure_logging()`,
then used in `airflow/utils/dag_processing.py`. But `logging_config` is still
not used anywhere.
Kindly let me know if I missed anything. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
