mik-laj commented on a change in pull request #4201: [AIRFLOW-3360] Make the
DAGs search respect other querystring parameters
URL: https://github.com/apache/incubator-airflow/pull/4201#discussion_r238061428
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -233,11 +233,32 @@ <h2>DAGs</h2>
const DAGS_INDEX = "{{ url_for('admin.index') }}";
const ENTER_KEY_CODE = 13;
+ function createOrAppendToQueryString(parameter, value) {
+ var query_string_parameters = {};
+ if (typeof window.location.search !== "undefined") {
+ window.location.search.substr(1).split('&').forEach(function
(query_string_parameter) {
+ query_string_parameter_delimeted =
query_string_parameter.split('=');
+ query_string_key = query_string_parameter_delimeted.shift();
+ query_string_value = query_string_parameter_delimeted.join('=');
+ query_string_parameters[query_string_key] = query_string_value
+ });
+ }
+ if (window.location.search == "") {
+ query_string_parameters = {};
Review comment:
I can not imagine the case when this line does something. This variable
already contains an empty object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
