kaxil commented on a change in pull request #4253: [AIRFLOW-3414] Fix 
reload_module in DagFileProcessorAgent
URL: https://github.com/apache/incubator-airflow/pull/4253#discussion_r238094129
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -539,7 +541,9 @@ def helper():
             # e.g. RotatingFileHandler. And it can cause connection corruption 
if we
             # do not recreate the SQLA connection pool.
             os.environ['CONFIG_PROCESSOR_MANAGER_LOGGER'] = 'True'
-            reload_module(airflow.config_templates.airflow_local_settings)
+            # Replicating the behavior of how logging module was loaded
+            # in logging_config.py
+            reload_module(import_module(logging_class_path.rsplit('.', 1)[0]))
 
 Review comment:
   Oh yes, my bad 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to