[
https://issues.apache.org/jira/browse/AIRFLOW-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706381#comment-16706381
]
ASF GitHub Bot commented on AIRFLOW-3412:
-----------------------------------------
torquerrr opened a new pull request #4268: [AIRFLOW-3412] Fix kubernetes
executor to delete pods after termination
URL: https://github.com/apache/incubator-airflow/pull/4268
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3412
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
- We need to pass 'try_number' parameter during the pod creation in
kubernetes_executor.py, otherwise '_labels_to_key' function will always raise
KeyError, making self.result_queue empty.
- As a result '_change_state' function in kubernetes_executor.py will
never be called and pods will keep hanging after termination even if other pod
deletion conditions are met.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Not sure how to write one for this particular case, maybe someone will
help?
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Worker pods are not being deleted after termination
> ---------------------------------------------------
>
> Key: AIRFLOW-3412
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3412
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor, kubernetes
> Affects Versions: 1.10.0
> Reporter: Viktor
> Assignee: Viktor
> Priority: Major
> Fix For: 1.10.2
>
>
> When using KubernetesExecutor multiple pods are spawned for tasks.
> When their job is done they are not deleted automatically even if you specify
> *delete_worker_pods=true* in the Airflow configuration and RBAC is properly
> configured to allow the scheduler to delete pods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
