ashb commented on a change in pull request #4276: [AIRFLOW-1552] Airflow
Filter_by_owner not working with password_auth
URL: https://github.com/apache/incubator-airflow/pull/4276#discussion_r238708599
##########
File path: airflow/contrib/auth/backends/password_auth.py
##########
@@ -106,8 +102,8 @@ def load_user(userid, session=None):
if not userid or userid == 'None':
return None
- user = session.query(models.User).filter(models.User.id ==
int(userid)).first()
- return PasswordUser(user)
+ user = session.query(PasswordUser).filter(PasswordUser.id ==
int(userid)).first()
Review comment:
This change looks better, but I need to check it doesn't actually break
other things - parts of the code may expect user.user to exist (as bonkers as
that sounds)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
