ashb commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that
the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r240056611
##########
File path: airflow/api/common/experimental/mark_tasks.py
##########
@@ -180,18 +180,15 @@ def set_state(task, execution_date, upstream=False,
downstream=False,
tis_altered += qry_sub_dag.with_for_update().all()
for ti in tis_altered:
ti.state = state
- session.commit()
else:
tis_altered = qry_dag.all()
if len(sub_dag_ids) > 0:
tis_altered += qry_sub_dag.all()
- session.expunge_all()
Review comment:
Removing this line is going to change the behaviour of this function I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
