[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718492#comment-16718492
]
ASF GitHub Bot commented on AIRFLOW-3501:
-----------------------------------------
gsilk opened a new pull request #4308: [AIRFLOW-3501] Add celery config option
for setting "pool"
URL: https://github.com/apache/incubator-airflow/pull/4308
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/3501) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Basically, this just adds a config option to the "celery" config for setting
the "pool", which defaults to "prefork", but some users may want to use "solo"
or other options.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This is a fairly simple change. Also, I'm not sure how to test it.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add config option to load dags in an image with the kubernetes executor.
> ------------------------------------------------------------------------
>
> Key: AIRFLOW-3501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3501
> Project: Apache Airflow
> Issue Type: Improvement
> Components: kubernetes
> Reporter: Kevin Pullin
> Priority: Major
>
> Currently the airflow kubernetes executor forces loading dags either from a
> volume claim or an init container. There should be an option to bypass these
> settings and instead use dags packaged into the running image.
> The motivation for this change is to allow for an airflow image to be built
> and released via a CI/CD pipeline upon a new commit to a dag repository. For
> example, given a new git commit to a dag repo, a CI/CD server can build an
> airflow docker image, run tests against the current dags, and finally push
> the entire bundle as a single, complete, well-known unit to kubernetes.
> There's no need to worry that a git init container will fail, having to have
> a separate pipeline to update dags on a shared volume, etc. And if issues
> arise from an update, the configuration can be easily rolled back to the
> prior version of the image.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
