Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure
that the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r241308955
##########
File path: airflow/bin/cli.py
##########
@@ -456,14 +448,12 @@ def _run(args, dag, ti):
if args.ship_dag:
try:
# Running remotely, so pickling the DAG
- session = settings.Session()
- pickle = DagPickle(dag)
- session.add(pickle)
- session.commit()
- pickle_id = pickle.id
- # TODO: This should be written to a log
- print('Pickled dag {dag} as pickle_id:{pickle_id}'
Review comment:
Good point @mik-laj
The line is unrelated to the code, but I will push the fix in this PR anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
