ashb commented on a change in pull request #4322: [AIRFLOW-3518] Performance 
fixes for topological_sort
URL: https://github.com/apache/incubator-airflow/pull/4322#discussion_r241803078
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -2662,10 +2662,15 @@ def __init__(
         }
 
     def __eq__(self, other):
-        return (
-            type(self) == type(other) and
-            all(self.__dict__.get(c, None) == other.__dict__.get(c, None)
-                for c in self._comps))
+        if (type(self) == type(other) and
+                self.task_id == other.task_id):
 
 Review comment:
   (And if we do we should probably add a test that checks that covers that)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to