ashb commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere URL: https://github.com/apache/incubator-airflow/pull/4317#issuecomment-447577053 I don't feel strongly either way about this PR. It would be possible to rename (if we decide that's what we want to do) and to have a deprecated import to make the upgrade path easier -- it's easy to maintain this shim for a release or two past 2.0 (say to 2.1 or 2.2) A random point: I think the naming of things is a little bit all-over the place, now that you mention it, and I think we should have something like this (as a non-representative sample): (I am *not* saying we should make this change, it's just my immediate thought) * Remove `_hook` suffix from the module name We don't need "hook" or "hooks" in the module, as it's already there from the parent ```python from airflow.hooks.hive import HiveServer2Hook, HiveCliHook ``` * Have related operators in the same module: Rather than ```python from airflow.operators.emr_add_step_operator import EmrAddStepOperator from airflow.operators.emr_create_job_flow_operator import EmrCreateJobFlowOperator ``` I think we should group closely related operators together like this. ```python from airflow.operators.emr import EmrAddStepOperator, EmrCreateJobFlowOperator ``` * Entirely drop the `contrib` folder module. We as a project have a copyright grant on all code, and have to maintain it all equally. I think the contrib folder made more sense when Airflow belonged to AirB'n'B but isn't useful now. .... This should probably be an AIP. 😀
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
