[
https://issues.apache.org/jira/browse/AIRFLOW-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723048#comment-16723048
]
ASF GitHub Bot commented on AIRFLOW-3522:
-----------------------------------------
mholtzscher opened a new pull request #4332: [AIRFLOW-3522] Add support for
sending Slack attachments
URL: https://github.com/apache/incubator-airflow/pull/4332
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/AIRFLOW-3522) issues and
references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3522
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
Adding support for sending Slack attachments with messages via the
SlackWebhookOperator. This will allow customized messages to be sent with
interactive content.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Modified test_slack_webhook_hook.py
- Modified test_slack_webhook_operator.py
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Slack Attachments for SlackWebhookHook
> ----------------------------------------------
>
> Key: AIRFLOW-3522
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3522
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
> Reporter: Michael Holtzscher
> Assignee: Michael Holtzscher
> Priority: Minor
>
> The SlackWebhookHook and SlackWebhookOperator do not support sending
> attachments. Adding support for attachments would allow for a much more full
> featured Slack messaging experience.
>
> [Slack Documentation|https://api.slack.com/docs/message-attachments]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
