mholtzscher commented on a change in pull request #4332: [AIRFLOW-3522] Add
support for sending Slack attachments
URL: https://github.com/apache/incubator-airflow/pull/4332#discussion_r242225597
##########
File path: airflow/contrib/hooks/slack_webhook_hook.py
##########
@@ -38,6 +38,8 @@ class SlackWebhookHook(HttpHook):
:type webhook_token: str
:param message: The message you want to send on Slack
:type message: str
+ :param attachments: The attachments you want to send on Slack
+ :type attachments: list
Review comment:
Slack kind of misuses the work attachments in my opinion. It is a list of
dicts and not really files that you are attaching. I will update the doc to be
clearer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
