ashb commented on issue #4325: [AIRFLOW-3528] handle socket exception with 
SFTPOperator
URL: 
https://github.com/apache/incubator-airflow/pull/4325#issuecomment-448236255
 
 
   This fix I don't think will do what we want, as I think now this will end up 
ultimately logging this as a message:
   
   > Error while transferring None, error: Error while connecting client, 
error: socket timed out
   
   (I took a guess at what might be in the OSError).
   
   Which means we probably need to add some tests, via mocking, that makes 
`open_sftp` fail with an exception. And then once we have tests we can be sure 
the error is reported right in this case.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to