[ 
https://issues.apache.org/jira/browse/AIRFLOW-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724451#comment-16724451
 ] 

ASF GitHub Bot commented on AIRFLOW-2082:
-----------------------------------------

rgangopadhya opened a new pull request #4343: [AIRFLOW-2082] Resolve a bug in 
adding password_auth to API as auth method
URL: https://github.com/apache/incubator-airflow/pull/4343
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW-2082) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
     - The current docs indicate that password authentication can be added to 
the experimental REST API by adding `auth_backend = 
airflow.contrib.auth.backends.password_auth` to the api config. This fails with 
`AttributeError: module 'airflow.contrib.auth.backends.password_auth' has no 
attribute 'client_auth'`. This PR follows the suggestion in the JIRA ticket to 
simply add `client_auth = None`
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   If there are existing tests around config, would be nice to add this in 
there. I took a quick look and didn't see any. 
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Password Web Authentication is not working
> ------------------------------------------
>
>                 Key: AIRFLOW-2082
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2082
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: authentication
>    Affects Versions: 1.8.0
>            Reporter: Andrey
>            Assignee: Brian Charous
>            Priority: Major
>
> I followed instruction from 
> [https://github.com/apache/incubator-airflow/blob/master/docs/security.rst#password]
> and as a result scheduler is unable to start anymore
> {code}
> scheduler_1 | [2018-02-08 17:46:49,546] \{configuration.py:206} WARNING - 
> section/key [celery/celery_ssl_active] not found in config
> scheduler_1 | [2018-02-08 17:46:49,550] \{default_celery.py:41} WARNING - 
> Celery Executor will run without SSL
> scheduler_1 | [2018-02-08 17:46:49,553] \{__init__.py:45} INFO - Using 
> executor CeleryExecutor
> scheduler_1 | 
> /usr/local/lib/python3.6/site-packages/psycopg2/__init__.py:144: UserWarning: 
> The psycopg2 wheel package will be renamed from release 2.8; in order to keep 
> installing from binary please use "pip install psycopg2-binary" instead. For 
> details see: 
> <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
> scheduler_1 | """)
> scheduler_1 | Traceback (most recent call last):
> scheduler_1 | File "/usr/local/bin/airflow", line 17, in <module>
> scheduler_1 | from airflow.bin.cli import CLIFactory
> scheduler_1 | File 
> "/usr/local/lib/python3.6/site-packages/airflow/bin/cli.py", line 67, in 
> <module>
> scheduler_1 | auth=api.api_auth.client_auth)
> scheduler_1 | AttributeError: module 
> 'airflow.contrib.auth.backends.password_auth' has no attribute 'client_auth'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to