kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure
that the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r243452987
##########
File path: airflow/bin/cli.py
##########
@@ -423,14 +418,11 @@ def unpause(args, dag=None):
def set_is_paused(is_paused, args, dag=None):
dag = dag or get_dag(args)
- session = settings.Session()
- dm = session.query(DagModel).filter(
- DagModel.dag_id == dag.dag_id).first()
- dm.is_paused = is_paused
- session.commit()
Review comment:
Isn't the `commit` on
https://github.com/apache/incubator-airflow/blob/master/airflow/utils/db.py#L45
after `expunge_all` which would remove all the object instance from the session?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
