ASF GitHub Bot commented on AIRFLOW-3555:

feng-tao closed pull request #4352: [AIRFLOW-3555] Remove lxml dependency
URL: https://github.com/apache/incubator-airflow/pull/4352

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/setup.py b/setup.py
index 56b9bb2873..f1e97d6b8f 100644
--- a/setup.py
+++ b/setup.py
@@ -316,7 +316,6 @@ def do_setup():
             'jinja2>=2.7.3, <=2.10.0',
-            'lxml>=4.0.0',
             'markdown>=2.5.2, <3.0',
             'pandas>=0.17.1, <1.0.0',


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Remove lxml dependency
> ----------------------
>                 Key: AIRFLOW-3555
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3555
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 1.9.0, 1.10.0, 1.10.1
>            Reporter: Jimmy Cao
>            Assignee: Jimmy Cao
>            Priority: Major
> In this PR: 
> [https://github.com/apache/incubator-airflow/pull/1712/files#diff-948e87b4f8f644b3ad8c7950958df033]
>  lxml was added to airflow/www/views.py, and then in this following PR: 
> [https://github.com/apache/incubator-airflow/pull/1722]  the lxml package was 
> added to the list of core dependencies.
> However, months later in this commit: 
> [https://github.com/apache/incubator-airflow/commit/1accb54ff561b8d745277308447dd6f9d3e9f8d5#diff-948e87b4f8f644b3ad8c7950958df033]
>  the lxml import was removed from airflow/www/views.py so it is no longer 
> needed except in the devel extras because it's still used in tests.
> It should be removed from the install_requires list.

This message was sent by Atlassian JIRA

Reply via email to