[ 
https://issues.apache.org/jira/browse/AIRFLOW-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727526#comment-16727526
 ] 

ASF GitHub Bot commented on AIRFLOW-3558:
-----------------------------------------

holdenk opened a new pull request #4361: [AIRFLOW-3558] Improve default tox 
flake8 excludes
URL: https://github.com/apache/incubator-airflow/pull/4361
 
 
   Right now our gitignore skips a bunch of temporary Python directories
   but our flake8 config will still test against them, leading to
   unnecessary error messages. This changes the excludes
   to skip the common directories that can cause false flake8 failures.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   Right now our gitignore skips a bunch of temporary Python directories
   but our flake8 config will still test against them, leading to
   unnecessary error messages. This changes the excludes
   to skip the common directories that can cause false flake8 failures.
   
   This should not impact end users.
   
   ### Tests
   
   - [ X ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   The existing flake8 env still runs from tox
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ X ] In case of new functionality, my PR adds documentation that 
describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
   
   No new functionality.
   
   ### Code Quality
   
   - [ X ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Have tox flake8 skip ignored and hidden directories
> ---------------------------------------------------
>
>                 Key: AIRFLOW-3558
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3558
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: holdenk
>            Assignee: holdenk
>            Priority: Trivial
>
> By default if you run tox with the flake8 target in Airflow it checks all of 
> the directories, this includes .eggs, env, etc. all of which are ignored by 
> our gitignore but cat by flake8 and gives a bunch of errors for non-Airflow 
> code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to