This is an automated email from the ASF dual-hosted git repository.

brondsem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/allura.git


The following commit(s) were added to refs/heads/master by this push:
     new dff1ab371 fix error on feed url for non-existant ticket
dff1ab371 is described below

commit dff1ab371ba70b3a2f33d55b04cf93aec8c0373b
Author: Dave Brondsema <[email protected]>
AuthorDate: Wed Aug 9 13:24:46 2023 -0400

    fix error on feed url for non-existant ticket
---
 ForgeTracker/forgetracker/tests/functional/test_root.py | 2 ++
 ForgeTracker/forgetracker/tracker_main.py               | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/ForgeTracker/forgetracker/tests/functional/test_root.py 
b/ForgeTracker/forgetracker/tests/functional/test_root.py
index 2d869f42d..4ed46201b 100644
--- a/ForgeTracker/forgetracker/tests/functional/test_root.py
+++ b/ForgeTracker/forgetracker/tests/functional/test_root.py
@@ -1624,6 +1624,8 @@ class TestFunctionalController(TrackerTestController):
         assert 'Tis a reply' in r
         assert 'ticket discussion post content' in r
 
+        self.app.get('/bugs/9999/feed.rss', status=404)
+
     def test_bulk_edit_index(self):
         self.new_ticket(summary='test first ticket', status='open')
         self.new_ticket(summary='test second ticket', status='accepted')
diff --git a/ForgeTracker/forgetracker/tracker_main.py 
b/ForgeTracker/forgetracker/tracker_main.py
index d2dcc20cf..367de3402 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -1397,6 +1397,8 @@ class TicketController(BaseController, FeedController):
         Overrides :meth:`allura.controllers.feed.FeedController.get_feed`.
 
         """
+        if not self.ticket:
+            return None
         title = 'Recent changes to %d: %s' % (
             self.ticket.ticket_num, self.ticket.summary)
         return FeedArgs(

Reply via email to