Updated Branches: refs/heads/trunk 89f4ef3d0 -> e8594a9cb
AMBARI-3916. When trying to duplicate Default Group js error occures. (onechiporenko) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/e8594a9c Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/e8594a9c Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/e8594a9c Branch: refs/heads/trunk Commit: e8594a9cb640c2f25a1d61fa22aab157a06eb0ac Parents: 89f4ef3 Author: Oleg Nechiporenko <[email protected]> Authored: Thu Nov 28 16:59:53 2013 +0200 Committer: Oleg Nechiporenko <[email protected]> Committed: Thu Nov 28 17:03:13 2013 +0200 ---------------------------------------------------------------------- .../controllers/main/service/manage_config_groups_controller.js | 3 +++ .../templates/main/service/manage_configuration_groups_popup.hbs | 2 +- ambari-web/app/views/main/service/manage_config_groups_view.js | 4 ++++ 3 files changed, 8 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/e8594a9c/ambari-web/app/controllers/main/service/manage_config_groups_controller.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/controllers/main/service/manage_config_groups_controller.js b/ambari-web/app/controllers/main/service/manage_config_groups_controller.js index 50a8165..ed13fc9 100644 --- a/ambari-web/app/controllers/main/service/manage_config_groups_controller.js +++ b/ambari-web/app/controllers/main/service/manage_config_groups_controller.js @@ -462,6 +462,9 @@ App.ManageConfigGroupsController = Em.Controller.extend({ * duplicate config group */ duplicateConfigGroup: function() { + if(this.get('selectedConfigGroup.name') == "Default") { + return; + } this.addConfigGroup(true); this.get('addGroupPopup').set('header',Em.I18n.t('services.service.config_groups.duplicate_config_group_popup.header')); this.get('addGroupPopup').set('configGroupName', this.get('selectedConfigGroup.name') + ' Copy'); http://git-wip-us.apache.org/repos/asf/ambari/blob/e8594a9c/ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs b/ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs index 66ddd30..63e2c73 100644 --- a/ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs +++ b/ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs @@ -42,7 +42,7 @@ <li {{bindAttr class="view.isRenameButtonDisabled:disabled"}}> <a rel="button-info-dropdown" {{bindAttr data-original-title="view.renameButtonTooltip"}} {{action renameConfigGroup target="controller"}}>{{t services.service.config_groups_popup.rename}}</a> </li> - <li> + <li {{bindAttr class="view.isDuplicateButtonDisabled:disabled"}}> <a rel="button-info-dropdown" {{bindAttr data-original-title="view.duplicateButtonTooltip"}} {{action duplicateConfigGroup target="controller"}}>{{t services.service.config_groups_popup.duplicate}}</a> </li> </ul> http://git-wip-us.apache.org/repos/asf/ambari/blob/e8594a9c/ambari-web/app/views/main/service/manage_config_groups_view.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/views/main/service/manage_config_groups_view.js b/ambari-web/app/views/main/service/manage_config_groups_view.js index f36452e..1aa6be0 100644 --- a/ambari-web/app/views/main/service/manage_config_groups_view.js +++ b/ambari-web/app/views/main/service/manage_config_groups_view.js @@ -28,15 +28,19 @@ App.MainServiceManageConfigGroupView = Em.View.extend({ isRenameButtonDisabled: true, + isDuplicateButtonDisabled: true, + //Disable actions remove and rename for Default config group buttonObserver: function () { var selectedConfigGroup = this.get('controller.selectedConfigGroup'); if(selectedConfigGroup.isDefault){ this.set('isRemoveButtonDisabled', true); this.set('isRenameButtonDisabled', true); + this.set('isDuplicateButtonDisabled', true); }else{ this.set('isRemoveButtonDisabled', false); this.set('isRenameButtonDisabled', false); + this.set('isDuplicateButtonDisabled', false); } }.observes('controller.selectedConfigGroup', 'controller.isHostsModified'),
