AMBARI-7436. Slider View: access deep within view instance after ambari-server restarted it throws error
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/d09adabc Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/d09adabc Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/d09adabc Branch: refs/heads/branch-alerts-dev Commit: d09adabcda1f30155f1a60a0c2c6a62a70ca50c6 Parents: 061fb88 Author: Srimanth Gunturi <[email protected]> Authored: Tue Sep 23 11:14:30 2014 -0700 Committer: Srimanth Gunturi <[email protected]> Committed: Tue Sep 23 11:14:30 2014 -0700 ---------------------------------------------------------------------- .../slider/SliderAppsViewControllerImpl.java | 27 ++++++++++---------- 1 file changed, 14 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/d09adabc/contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java ---------------------------------------------------------------------- diff --git a/contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java b/contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java index f60ac3b..3ab4829 100644 --- a/contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java +++ b/contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java @@ -82,7 +82,6 @@ import com.google.inject.Singleton; @Singleton public class SliderAppsViewControllerImpl implements SliderAppsViewController { - private static final Logger logger = Logger .getLogger(SliderAppsViewControllerImpl.class); private static String METRICS_PREFIX = "metrics/"; @@ -175,19 +174,21 @@ public class SliderAppsViewControllerImpl implements SliderAppsViewController { } @Override - public SliderApp getSliderApp(String applicationId, final Set<String> properties) - throws YarnException, IOException, InterruptedException { - final ApplicationId appId = getApplicationId(applicationId); - if (appId != null) { - return invokeSliderClientRunnable(new SliderClientContextRunnable<SliderApp>() { - @Override - public SliderApp run(SliderClient sliderClient) throws YarnException, IOException { - ApplicationReport yarnApp = sliderClient.getApplicationReport(appId); - return createSliderAppObject(yarnApp, properties, sliderClient); + public SliderApp getSliderApp(final String applicationId, final Set<String> properties) + throws YarnException, IOException, InterruptedException { + return invokeSliderClientRunnable(new SliderClientContextRunnable<SliderApp>() { + @Override + public SliderApp run(SliderClient sliderClient) throws YarnException, IOException { + if (applicationId!=null) { + ApplicationId appId = getApplicationId(applicationId); + if (appId != null) { + ApplicationReport yarnApp = sliderClient.getApplicationReport(appId); + return createSliderAppObject(yarnApp, properties, sliderClient); + } } - }); - } - return null; + return null; + } + }); } private SliderApp createSliderAppObject(ApplicationReport yarnApp,
